Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yaml to 2.5.1 #12103

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 2, 2024

Summary

This bumps yaml to 2.5.1

Fixes #12090

Areas or cases that should be tested

It looks like this dependency is only used in pkg/harvester-manager/machine-config/harvester.vue

Areas which could experience regressions

  • pkg/harvester-manager/machine-config/harvester.vue

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.10.0 milestone Oct 2, 2024
@rak-phillip rak-phillip requested a review from torchiaf October 2, 2024 22:17
@rak-phillip rak-phillip self-assigned this Oct 2, 2024
Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip rak-phillip force-pushed the chore/12090-bump-yaml branch from 9268c87 to 9450d60 Compare October 2, 2024 22:18
@torchiaf
Copy link
Member

torchiaf commented Oct 7, 2024

I'm working on it.

Copy link
Member

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the YAML dependency is used to handle the User Data field as a yaml.
I didn't find any regression testing that field in Harvester creation page.

@rak-phillip rak-phillip merged commit c557b51 into rancher:master Oct 8, 2024
32 checks passed
@rak-phillip rak-phillip deleted the chore/12090-bump-yaml branch October 8, 2024 15:18
@rak-phillip rak-phillip mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml: >=2.2.2
2 participants