Clusters can be created/edited with broken add-on config yaml file

[IsaSih]

Setup

• Rancher version: v2.9-50aecc403a523ef45c90de73e99ec2cde182f627-head

Describe the bug
Found while testing #12067
Clusters can be created/edited with broken add-on yaml files. We need a yaml validator for the add-on config as they are now displayed in separate tabs.

To Reproduce
1- From the Clusters Management in the UI, hit Create
2- Select rke2, Input your cloud credentials, fill all the mandatory fields, then select a container network add-on
3- Navigate to the container network tab, and brake the yaml file
4- Hit create

Result
UI allows clusters to be created with broken add-on yaml files.

Expected Result
UI must have a yaml validator for the add-on config file, that displays an error message and prevents a cluster to be created if the yaml files are broken. Same behavior should be applied for the edit form.

Screen.Recording.2024-10-22.at.10.24.14.mov

[IsaSih]

Observed that the yaml file is overwritten during the provisioning and the cluster gets created with no errors. But the validator brings a better UX.

[gaktive]

It doesn't sound like a blocker but we'll release note it for 2.9.3 and fix for 2.10.0 & 2.9.4

[gaktive]

/backport v2.9.4

[IsaSih]

/backport v2.8.10

[kwwii]

We should show the errors in the yaml file view also in the tab for the add-on config so that users are aware of the errors when viewing another tab. As long as there are errors the submit action should be disabled.

[mantis-toboggan-md]

This is effectively blocked by #12418; the content of these tabs changes unexpectedly when the user navigates away/back to the tab.

[gaktive]

/backport v.2.10.1

[github-actions]

Not creating port issue, milestone v.2.10.1 does not exist or is not an open milestone

[gaktive]

/backport v2.10.1

[gaktive]

As noted, blocked. We'd need to prioritize #12418 and then figure out its backports.

[yonasberhe23]

User is unable to save/create cluster with broken config yaml

Tested in:

• Rancher v2.11-2053ce644a31cd8053d1f58e2487154b0b8513b6-head
• Dashboard master 0c6eb64