Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Require Namespace Filtering to projects and multiple projects/namespaces #7618

Closed
richard-cox opened this issue Dec 5, 2022 · 7 comments · Fixed by #8757
Closed

Comments

@richard-cox
Copy link
Member

Original Issue - #6483

Once the BE team update API filtering to cover projects and multiple namespaces this feature should be updated to use them. I don't think that work has a separate ticket, but is done via the pagination work

@richard-cox
Copy link
Member Author

richard-cox commented Jan 27, 2023

This will be achievable once rancher/rancher#40141 has been completed

Edit: Actual issue is rancher/rancher#40140

Edit2: Related PR is now rancher/steve#105. I think there also needs to be a bump in rancher/rancher afterwards as well

@gaktive
Copy link
Member

gaktive commented May 5, 2023

Related backend is now To Test so UI unblocked.

@gaktive
Copy link
Member

gaktive commented May 11, 2023

rancher/rancher#40140 is undergoing some revision; once that's sorted, this should unblock UI.

@richard-cox richard-cox changed the title Expand Required Namespace Filtering to projects and multiple namespaces Expand Require Namespace Filtering to projects and multiple projects/namespaces May 15, 2023
@github-actions github-actions bot reopened this May 18, 2023
@zube zube bot removed the [zube]: Done label May 18, 2023
@floatingman
Copy link

Tested the issue by performing the following steps

  1. Enabling the updated performance setting in Global Settings (Advanced Websocket Worker, Required Namespace/ Project Filtering)
  2. Verified the following
    1. All workloads list fetch the correct data (via http request)
    2. New endpoint is hit for primary resource type, only resources from selected namespaces/projects are shown
    3. New endpoint is hit for all secondary resource types
    4. All workloads list update with the correct data (via socket)
    5. Changes to resources in the list are automatically shown (when changed via another context/browser/etc)
    6. Changes to resource not in the list do not show (creating a new resource not in a selected namespace/project doesn't appear in the list)
  3. Creating resources works fine
  4. Navigate to a create page of a resource (deployment, pod). Resource can be created, user is returned to the resource list and, if the resource was created in a namespace in the filter, the new resource should be shown
  5. Edit resources work fine
  6. Navigate to an existing resource page (deployment, pod). Resource can be edited, user is returned to the resource list and the edited resource should be shown
  7. Both Upstream and Downstream clusters work correctly

@richard-cox
Copy link
Member Author

Hi @floatingman , could you confirm you've tested this feature without the Advanced Websocket Worker feature enabled? Whilst the two can be used together, and there's some overlapping code, they're independent settings

@floatingman
Copy link

Yes, since the Advanced Websocket Worker isn't enabled by default, things like creating some resources (secrets and config maps) and importing downstream clusters where performed with it disabled.

@richard-cox
Copy link
Member Author

Perfect, thanks @floatingman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment