-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand enforced namespace filtering to multiple namespaces and projects #8757
Merged
richard-cox
merged 10 commits into
rancher:master
from
richard-cox:forced-project-filtering
May 18, 2023
Merged
Expand enforced namespace filtering to multiple namespaces and projects #8757
richard-cox
merged 10 commits into
rancher:master
from
richard-cox:forced-project-filtering
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
force-pushed
the
forced-project-filtering
branch
from
May 12, 2023 14:13
709e9be
to
fa94ebd
Compare
ghost
previously approved these changes
May 18, 2023
richard-cox
force-pushed
the
forced-project-filtering
branch
from
May 18, 2023 10:22
50b3086
to
9a92a0e
Compare
ghost
approved these changes
May 18, 2023
> This uses a new endpoint that has yet to merge. See rancher/rancher#40140 WIP - Contains console.warns (via custom logger, can be disabled) - Waiting for final BE endpoint changes to merge - Contains TODOs to resolve on final enpoint changes delivered Pertinent Points - Incompatible with incremental loading / manual refresh - Harder to get counts (need to sum up from different namespaces) - Requires use of new steve pagination - Enforced NS threshold has been removed - The threshold only applies to the primary resource. This has issues when loading a low count primary (daemon sets) which depends on a very high count secondary (pods) - Fixing this would involve knowing all secondary resources a list uses, which isn't currently possible (each resource is requested individually, need to know them all first) - There is no way to subscribe to multiple namespaces (one or all) - We mock this in subscribe by only persisting changes to resources from within target namespaces - Everything should work with Advanced Worker enabled
- Filtering is now no longer done via `resources.project.cattle.io.` - No need to update the URL anywhere or massage resources fetched via endpoint - Also no need to make the planned change to remove `resources.project.cattle.io.` from side nav
- Given forced filtering is now not resource dependent have a high level utils function to determine if enabled - This should have opened up the door to setting a nicer default then ALL_USER, however it's actually initially applied somewhere other than ns filter - Fixed a bug where the all option [] was valid
- Moving the store setting to enable/disable filtering in the store to a function in a computed property caused havoc for churn - Make this much neater by moving flag to the setup stage for both ns filter
richard-cox
force-pushed
the
forced-project-filtering
branch
from
May 18, 2023 13:29
9a92a0e
to
5feb263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7618
Occurred changes and/or fixed issues
Pertinent Points
Technical notes summary
Areas or cases that should be tested