Node Driver page does not handle errors

[thatmidwesterncoder]

SURE-9632

Setup

• Rancher version: v2.7 head
• Rancher UI Extensions: n/a
• Browser type & version: chrome 114

Describe the bug

When disabling/enabling a Node Driver if the API returns a 400/500 it does not display the error nor update the UI in anyway, which is confusing.

To Reproduce

Apply rancher/webhook#250 to the webhook, then try and disable a node driver after creating a cluster that uses one of the node drivers. Nothing will happen in the UI after clicking disable.

Result
Nothing happens when the request is denied.

Expected Result

A notification is shown with the error so the user knows what happened in the background when trying to disable/enable the driver.

Screenshots

Additional context

path: /dashboard/c/_/manager/pages/rke-drivers

This was found when developing rancher/rancher#41128, when adding the webhook which can deny an update on the NodeDriver resources

[richard-cox]

This is a general issue with how we handle requests related to actions that do not modify the resource state / message.

This page is currently in ember, but the pattern extends to dashboard as well.

We should look at / consider this when working on #9274

[thaneunsoo]

Hi just wanted to leave my findings here from rancher/rancher#42378

I noticed when activating both node drivers I noticed that one of the node drivers went into a Downloading state. Both are installed and active. I'm not sure if this is worth fixing for the ui since this is a very edge case, I'm ok with just having the backend working properly.

Even when uninstalling the active node driver, the downloading nodedriver stays in Downloading state in the UI. When looking at the api I see that the status is indeed in Downloading but when I check the nodedriver using kubectl I see that the node driver is actually installed and active.


I'm ok to close this out this ticket and keep this comment here as a reference but I don't think it is worth UI team's time to fix this edge case.

[richard-cox]

@timirnich that seems to be a separate issue, where two of the same drivers are added and the state supplied getting broken. Think the key issue on this one is the request fails and the UI does not show the error message.

Needs re-testing in 2.9.0 after this page was ported to vue

[XavierDuthil]

Hello, I would like to add that this issue also concerns Cluster/Kontainer drivers. We put a webhook in place to prevent any driver activation/deactivation and no error message is displayed when one of these operations is blocked.

[nwmac]

We need to add error handling into the models for node and kontainer drivers and into the deactivate dialogs used for those.

In the models, we should show a growl when an error occurs and for the modals, we should show the error in the modal.