-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions: Add hooks to support virtual clusters #11064
Open
nwmac
wants to merge
10
commits into
rancher:master
Choose a base branch
from
nwmac:add-virtual-cluster-hooks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+235
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
Add hooks to support virtual clusters
Extensions: Add hooks to support virtual clusters
May 23, 2024
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
3 times, most recently
from
June 14, 2024 17:09
3225ac2
to
82fc100
Compare
@mantis-toboggan-md finally got this to pass gates - refactored as we discussed. |
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
July 10, 2024 16:53
82fc100
to
37c7477
Compare
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
August 13, 2024 15:35
71c0394
to
29ec9b5
Compare
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
January 22, 2025 13:39
29ec9b5
to
06756d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11065
This PR adds several hooks for virtual cluster support.
The changes extend the provisioner helper and allow the cluster list to be grouped by host cluster when there are virtual clusters present.
Changes made in a way to be as least disruptive as possible.
We will refine these extension points in the future and document once stable.
Areas or cases that should be tested
These hooks will be tested by extensions.
Current e2e test should validate that the hooks do not break existing functionality.
Checklist