Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vai pagination tests - tokens #11257

Merged
merged 1 commit into from
Jul 4, 2024
Merged

vai pagination tests - tokens #11257

merged 1 commit into from
Jul 4, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Jun 17, 2024 •
edited
Loading

Summary

Fixes #rancher/qa-tasks#1380

  • Covers pagination functionality for tokens list under Account & API Keys.
  • Refactor pagination tests for events

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 self-assigned this Jun 17, 2024
@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone Jun 17, 2024
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch from bbe8e90 to 5559a91 Compare June 18, 2024 18:26
@yonasberhe23 yonasberhe23 marked this pull request as draft June 18, 2024 18:38
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch 6 times, most recently from 3ce14df to 3f1e1b8 Compare June 24, 2024 17:17
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch 3 times, most recently from a1d1e7c to f181a2a Compare June 28, 2024 17:40
@yonasberhe23 yonasberhe23 marked this pull request as ready for review June 28, 2024 18:03
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch from f181a2a to 6fe95cf Compare June 28, 2024 18:13
@yonasberhe23 yonasberhe23 requested a review from richard-cox June 28, 2024 18:15
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch 3 times, most recently from 8573b9a to 7eba328 Compare July 1, 2024 21:15
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch from 7eba328 to 2db8c79 Compare July 2, 2024 19:27
@yonasberhe23 yonasberhe23 requested a review from richard-cox July 2, 2024 19:28
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch from 2db8c79 to 7b1498a Compare July 2, 2024 21:53
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_apikeys branch from 7b1498a to f6a4589 Compare July 4, 2024 14:41
@yonasberhe23 yonasberhe23 merged commit 458bab5 into rancher:master Jul 4, 2024
26 checks passed
@yonasberhe23 yonasberhe23 deleted the vai_pagination_apikeys branch July 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
area/e2e
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yonasberhe23 @richard-cox