-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Show deprecated apps" filter to charts page + warning banners #11279
Added "Show deprecated apps" filter to charts page + warning banners #11279
Conversation
…rimental warnings
…rts-deprecation-and-experimental-warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add one step to the 'Show deprecated apps filter' to test the deprecated
query param being passed into the route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Jordon has already reviewed this and I addressed his only change request, and asked Cody to take a look since Jordon was off
…ancher#11279) * added show deprecated apps filter to charts page + deprecation & experimental warnings * lint * fix e2e test * test deprecated query parameter in the url --------- Co-authored-by: Mo Mesgin <[email protected]>
Summary
Fixes #11042
Occurred changes and/or fixed issues
deprecated
query parameter to the URL.deprecated
query parameter exists in the URL the checkbox will be enabled by default.deprecated
query parameter is added to the chart's URL.Areas or cases that should be tested
Using different filters on the charts page, and make sure the above items are working as expected.
Areas which could experience regressions
Make sure the charts and chart's detail pages are working as expected.
Screenshot/Video
Screen.Recording.2024-06-20.at.6.05.03.PM.mov
Checklist