Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Show deprecated apps" filter to charts page + warning banners #11279

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Jun 21, 2024

Summary

Fixes #11042

Occurred changes and/or fixed issues

  • Previously, the only way to see deprecated apps on the Charts page was by adding the deprecated query parameter to the URL.
  • A new checkbox labeled "Show deprecated apps" has been added to the Charts page, which is disabled by default.
  • If the deprecated query parameter exists in the URL the checkbox will be enabled by default.
  • If the checkbox is enabled you'll be able to see the deprecated charts.
  • A "Deprecated" badge is shown on each card, if a chart is both deprecated and experimental, only the deprecated badge will be shown.
  • Previously, a deprecated chart's page was kinda broken since we did not make an API call to retrieve the chart's information.
  • When the "Show deprecated apps" filter is enabled and you click on a card, a deprecated query parameter is added to the chart's URL.
  • Warning banners will be displayed on the chart's page for deprecated, experimental, or both statuses.

Areas or cases that should be tested

Using different filters on the charts page, and make sure the above items are working as expected.

Areas which could experience regressions

Make sure the charts and chart's detail pages are working as expected.

Screenshot/Video

Screen.Recording.2024-06-20.at.6.05.03.PM.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.9.0 milestone Jun 21, 2024
@momesgin momesgin requested review from nwmac and jordojordo June 21, 2024 01:07
@momesgin momesgin self-assigned this Jun 21, 2024
@momesgin momesgin changed the title Added "Show deprecated apps" filter to charts page plus warnings Added "Show deprecated apps" filter to charts page + warnings banners Jun 21, 2024
@momesgin momesgin changed the title Added "Show deprecated apps" filter to charts page + warnings banners Added "Show deprecated apps" filter to charts page + warning banners Jun 21, 2024
Mo Mesgin added 2 commits June 21, 2024 16:01
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add one step to the 'Show deprecated apps filter' to test the deprecated query param being passed into the route?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@momesgin momesgin dismissed jordojordo’s stale review June 27, 2024 17:54

Jordon has already reviewed this and I addressed his only change request, and asked Cody to take a look since Jordon was off

@momesgin momesgin merged commit fb2c9e5 into rancher:master Jun 27, 2024
26 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
…ancher#11279)

* added show deprecated apps filter to charts page + deprecation & experimental warnings

* lint

* fix e2e test

* test deprecated query parameter in the url

---------

Co-authored-by: Mo Mesgin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add deprecation warning on SRIOV chart in UI
3 participants