Add agent tls mode to global settings #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Jun 25, 2024
richard-cox
previously approved these changes
Jun 25, 2024
|
@jordojordo This looks like it was approved but then commits pushed - don't know if that was to get a fix for e2e tests? It looks like the automated test that was added is failing. |
Co-authored-by: Richard Cox <[email protected]>
…ed on previous test
nwmac
approved these changes
Jun 28, 2024
|
@jordojordo I fixed the e2e tests and rebased and bumped this PR - I think this is ready to be merged. |
jordojordo
added a commit
to jordojordo/dashboard
that referenced
this pull request
Aug 7, 2024
* Add agent tls mode to global settings * Update shell/assets/translations/en-us.yaml Co-authored-by: Richard Cox <[email protected]> * Move agent test to avoid issues with _ and local for cluster name based on previous test --------- Co-authored-by: Richard Cox <[email protected]> Co-authored-by: Neil MacDougall <[email protected]>
rak-phillip
added a commit
that referenced
this pull request
Aug 8, 2024
[Backport] Add agent tls mode to global settings (#11287)
nwmac
added a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* Add agent tls mode to global settings * Update shell/assets/translations/en-us.yaml Co-authored-by: Richard Cox <[email protected]> * Move agent test to avoid issues with _ and local for cluster name based on previous test --------- Co-authored-by: Richard Cox <[email protected]> Co-authored-by: Neil MacDougall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11138
Occurred changes and/or fixed issues
This will add the
agent-tls-modesetting to the Global Settings page, as well as a new optional propertywarningon theGlobalSettingsinterface that will display a warning banner when editing the setting.Technical notes summary
The setting is an
enumwith two values:strictandsystem-storeTo add a warning to the setting, the
advancedSettings.warningstranslation will require a property named after the setting, in this caseagent-tls-mode.Areas or cases that should be tested
Testing the setting works with both values, ensure the warning banner shows.
Areas which could experience regressions
N/A
Screenshot/Video
Checklist