-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automation] - Reduce execution time of pagination tests #11587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaac
added
the
QA/dev-automation
Issues that engineers have written automation around so QA doesn't have look at this
label
Aug 2, 2024
izaac
force-pushed
the
pagination_updates
branch
from
August 2, 2024 21:32
2eec06e
to
7f2ed49
Compare
I am debugging why are these failing in GH and not locally. |
izaac
force-pushed
the
pagination_updates
branch
from
August 5, 2024 17:15
7f2ed49
to
b7876f3
Compare
izaac
force-pushed
the
pagination_updates
branch
from
August 5, 2024 19:53
b7876f3
to
d08c913
Compare
Adding a |
izaac
force-pushed
the
pagination_updates
branch
9 times, most recently
from
August 8, 2024 00:44
b2a5b15
to
533209e
Compare
The pods mock test data was making a test fail. |
izaac
force-pushed
the
pagination_updates
branch
9 times, most recently
from
August 9, 2024 16:28
62cd323
to
41cdb1d
Compare
izaac
force-pushed
the
pagination_updates
branch
2 times, most recently
from
August 13, 2024 22:38
f7ff74c
to
40d507b
Compare
richard-cox
reviewed
Aug 14, 2024
izaac
force-pushed
the
pagination_updates
branch
from
August 14, 2024 21:18
40d507b
to
078b6c2
Compare
izaac
force-pushed
the
pagination_updates
branch
11 times, most recently
from
August 21, 2024 19:10
ef04f39
to
5035593
Compare
izaac
force-pushed
the
pagination_updates
branch
from
August 21, 2024 21:10
5035593
to
92fc735
Compare
yonasberhe23
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
QA/dev-automation
Issues that engineers have written automation around so QA doesn't have look at this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rancher/qa-tasks#1429
Occurred changes and/or fixed issues
Set the pagination to 10 rows per page.
Reduce the resources creation from 100 to 25 for the pagination tests.
Update the assertion logic accordingly.
Technical notes summary
This change reduces the resources creation to speed up the pagination tests execution.
Areas or cases that should be tested
Check the pagination tests pass the execution with the assertions updates.
Notes
This doesn't include the Global Roles tests in the meantime as that page/table has an slight different layout using tabbed tables.Found out the root cause of the issues with the Roles tests. Code is updated.
Checklist