Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] - Reduce execution time of pagination tests #11587

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Aug 2, 2024

Summary

Fixes rancher/qa-tasks#1429

Occurred changes and/or fixed issues

Set the pagination to 10 rows per page.
Reduce the resources creation from 100 to 25 for the pagination tests.
Update the assertion logic accordingly.

Technical notes summary

This change reduces the resources creation to speed up the pagination tests execution.

Areas or cases that should be tested

Check the pagination tests pass the execution with the assertions updates.

Notes

This doesn't include the Global Roles tests in the meantime as that page/table has an slight different layout using tabbed tables.

Found out the root cause of the issues with the Roles tests. Code is updated.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 2, 2024
@izaac izaac added this to the v2.10.0 milestone Aug 2, 2024
@izaac izaac requested review from richard-cox and IsaSih August 2, 2024 21:30
@izaac izaac self-assigned this Aug 2, 2024
@izaac izaac force-pushed the pagination_updates branch from 2eec06e to 7f2ed49 Compare August 2, 2024 21:32
@izaac
Copy link
Contributor Author

izaac commented Aug 5, 2024

I am debugging why are these failing in GH and not locally.

@izaac izaac force-pushed the pagination_updates branch from 7f2ed49 to b7876f3 Compare August 5, 2024 17:15
@izaac izaac marked this pull request as draft August 5, 2024 17:39
@izaac izaac force-pushed the pagination_updates branch from b7876f3 to d08c913 Compare August 5, 2024 19:53
@izaac
Copy link
Contributor Author

izaac commented Aug 5, 2024

Adding a cy.reload after changing the rows per page UI setting. Without it div.paging wasn't found when using less than 100.

@izaac izaac force-pushed the pagination_updates branch 9 times, most recently from b2a5b15 to 533209e Compare August 8, 2024 00:44
@izaac
Copy link
Contributor Author

izaac commented Aug 8, 2024

The pods mock test data was making a test fail. pagination is hidden in pods.spec

@izaac izaac force-pushed the pagination_updates branch 9 times, most recently from 62cd323 to 41cdb1d Compare August 9, 2024 16:28
@izaac izaac force-pushed the pagination_updates branch 2 times, most recently from f7ff74c to 40d507b Compare August 13, 2024 22:38
@izaac izaac force-pushed the pagination_updates branch from 5035593 to 92fc735 Compare August 21, 2024 21:10
@izaac izaac marked this pull request as ready for review August 21, 2024 21:10
@izaac izaac requested a review from yonasberhe23 August 21, 2024 22:55
@izaac izaac merged commit 866c642 into rancher:master Aug 22, 2024
28 checks passed
@izaac izaac deleted the pagination_updates branch August 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update Vai pagination tests
5 participants