Add kubewarden spec to extension compatibility tests #11668

aalves08 · 2024-08-19T17:52:05Z

Summary

Fixes #11482
Fixes #9232

Occurred changes and/or fixed issues

Add spec for Kubewarden e2e extension compatibility tests

Technical notes summary

Based on the work done in #11626, which needed a profound rebase from master which spawned this new PR.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
The PR has a Milestone
The PR template has been filled out
The PR has been self reviewed
The PR has a reviewer assigned
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

aalves08 · 2024-08-21T09:12:39Z

@richard-cox @jordojordo the usual cleanup is still needed because I wanted to demonstrate that the spec is working just fine.

@jordojordo I think we've covered what we discussed in terms of meaningful tests, right?

create an admission policy, trigger it and verify it in a compliance report
create a policy server via YAML

richard-cox

general approach looks good. there's a few POs that could wrap some existing. we might want to spin out some of the custom POs from the utils file at some point (if it grows)

cypress/e2e/po/edit/ingress.po.ts

cypress/e2e/po/pages/explorer/cronjob.po.ts

richard-cox · 2024-08-22T14:36:14Z

cypress/e2e/po/pages/explorer/projects-namespaces.po.ts

+    super(ProjectNamespaceDetailPagePo.createPath(clusterId, id));
+  }
+
+  clickComplianceTab() {


these two are specific to kw

I've created a new class in kubewarden.utils called KubewardenResourceComplianceReportPagePo which is the same for any resource, afaik, and then imported it in projectNamespaceDetail to be exposed as kubewardenComplianceReport, which will access the methods.

I think the context is correct, to keep it accessible in projectsNamespaces, but the "ownership" I think you are right. What do you think?

The aim is to keep kubewarden specific code out of generic code.

I might be wrong, but if the compliance tab is an kw specific additional tab in the detail page of a project. so suggest the hierarchy as

KubewardenResourceComplianceReportTabPo extends ComponentPo { complianceSortableTable() { return new SortableTablePo(this.self().get('#policy-report-tab .sortable-table')); } } KubewardenProjectNamespaceDetailPagePo extends ProjectNamespaceDetailPagePo { clickComplianceTab() { return new TabbedPo().clickTabWithSelector('[data-testid="btn-policy-report-tab"]'); } complianceTab() { return new KubewardenResourceComplianceReportTabPo(this.self()) } }

So there's a KW specific project namespace detail page, inheriting all the root page functionality, exposing new KW specific functionality

cypress/e2e/po/edit/ingress.po.ts

cypress/e2e/po/extensions/kubewarden/kubewarden.utils.ts

aalves08 · 2024-08-22T17:06:10Z

@richard-cox did a few changes based on your comments, but since it generally looks good, tomorrow I am going to base my work on neuvector spec on this PR. Thank you for your time looking into this! 🙏

jordojordo

LGTM - small comment about the naming scheme, and I think those gates are ready to be removed.

.github/workflows/check-plugins.yaml

cypress/e2e/po/extensions/kubewarden/kubewarden.utils.ts

… the utils files + comment unwanted workflow runs

…s expected

…e report test in KW spec + add KW spec as a runner in the PR workflow + temporary comment slack messaging on PR as it throws error because of secret

richard-cox · 2024-09-03T12:36:49Z

cypress/e2e/po/pages/explorer/projects-namespaces.po.ts

+    super(ProjectNamespaceDetailPagePo.createPath(clusterId, id));
+  }
+
+  kubewardenComplianceReport() {


This would be rmeoved as part of #11668 (comment)

richard-cox · 2024-09-03T12:38:55Z

cypress/e2e/po/pages/explorer/cronjob.po.ts

+
+  successfulCountCheck(countExpected: number, timeout = 15000) {
+    // let's give it a buffer for the job to finish running
+    cy.wait(timeout); // eslint-disable-line cypress/no-unnecessary-waiting


you should be able to extend the time get allows for an element to appear by passing in args to cy.get (check out usages of MEDIUM_TIMEOUT_OPT, LONG_TIMEOUT_OPT, EXTRA_LONG_TIMEOUT_OPT)

richard-cox · 2024-09-03T12:39:55Z

cypress/e2e/po/pages/explorer/ingress.po.ts

+        expect(response?.body.metadata).to.have.property('namespace', namespaceToCheck);
+      }
+
+      cy.wait(5000); // eslint-disable-line cypress/no-unnecessary-waiting


why is there a 5 second wait here?

richard-cox · 2024-09-03T12:41:14Z

cypress/e2e/po/pages/explorer/cronjob.po.ts

+    // let's give it a buffer for the job to finish running
+    cy.wait(timeout); // eslint-disable-line cypress/no-unnecessary-waiting
+
+    return cy.get('.gauges__pods div:nth-child(1) div h1').invoke('text').should('contain', countExpected);


Feels like this should be a CountGauge PO

richard-cox · 2024-09-03T12:43:03Z

cypress/e2e/po/extensions/kubewarden/kubewarden.utils.ts

+      expect(response?.statusCode).to.eq(201);
+      expect(response?.body.metadata).to.have.property('name', nameToCheck);
+
+      cy.wait(5000); // eslint-disable-line cypress/no-unnecessary-waiting


why's there a wait here?

richard-cox · 2024-09-03T12:46:36Z

cypress/e2e/tests/extensions/kubewarden/kubewarden.spec.ts

+
+    extensionsPo.addExtensionsRepositoryDirectLink(EXTENSION_REPO, EXTENSION_BRANCH, EXTENSION_CLUSTER_REPO_NAME, true);
+    // let's wait a bit so that the repo is available in extensions screen
+    cy.wait(10000); // eslint-disable-line cypress/no-unnecessary-waiting


this should be achievable with a should or get with timeout

richard-cox · 2024-09-03T12:48:09Z

cypress/e2e/tests/extensions/kubewarden/kubewarden.spec.ts

+    kubewardenPo.chartInstallPage().waitForChartPage('rancher-charts', 'rancher-monitoring');
+    // monitoring chart install page takes a bit to come up. The search for "rancherMonitoringInstallIntoProjectSelect"
+    // might fail because of this. Let's give it a time buffer here
+    cy.wait(10000); // eslint-disable-line cypress/no-unnecessary-waiting


there should be other ways to check for screen content is available, applies to all the cy.wait(10000)'s on page

aalves08 self-assigned this Aug 19, 2024

aalves08 added this to the v2.10.0 milestone Aug 19, 2024

aalves08 mentioned this pull request Aug 19, 2024

Add kubewarden spec to extension compatibility tests #11626

Closed

7 tasks

aalves08 force-pushed the 11482-add-kubewarden-spec branch from a4c688d to 97aaa24 Compare August 19, 2024 17:57

aalves08 mentioned this pull request Aug 20, 2024

Extensions: Vue 3 extension validation and compatibility #11482

Open

10 tasks

aalves08 marked this pull request as ready for review August 20, 2024 16:46

aalves08 requested review from richard-cox and jordojordo August 21, 2024 09:04

richard-cox reviewed Aug 22, 2024

View reviewed changes

aalves08 requested a review from richard-cox August 22, 2024 17:04

aalves08 mentioned this pull request Aug 26, 2024

Add Neuvector spec to extension compatibility tests #11692

Open

7 tasks

jordojordo requested changes Aug 26, 2024

View reviewed changes

.github/workflows/check-plugins.yaml Show resolved Hide resolved

cypress/e2e/po/extensions/kubewarden/kubewarden.utils.ts Outdated Show resolved Hide resolved

aalves08 added 9 commits August 28, 2024 16:08

redo PR based on previous PR 11626 and taking into account changes to…

22dd4b1

… the utils files + comment unwanted workflow runs

remove unused po

eb1b75d

bring PR back to old form where installation of backend parts works a…

4e42baa

…s expected

finish testing of install of backend parts in KW spec + add complianc…

3c62d60

…e report test in KW spec + add KW spec as a runner in the PR workflow + temporary comment slack messaging on PR as it throws error because of secret

finish kw spec

88edb3d

add a 2.10 head version to e2e tests

310c572

address pr comments

c180ad1

comment out fixed version of 2.10

bf7943b

address pr comments + fix merge conflicts

d5db1c2

aalves08 force-pushed the 11482-add-kubewarden-spec branch from 8c21d28 to d5db1c2 Compare August 28, 2024 15:10

aalves08 requested a review from jordojordo August 28, 2024 15:11

richard-cox requested changes Sep 3, 2024

View reviewed changes

nwmac modified the milestones: v2.10.0, v2.11.0, v2.12.0 Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add kubewarden spec to extension compatibility tests #11668

Add kubewarden spec to extension compatibility tests #11668

aalves08 commented Aug 19, 2024 •

edited by jordojordo

Loading

aalves08 commented Aug 21, 2024

richard-cox left a comment

richard-cox Aug 22, 2024

aalves08 Aug 22, 2024

richard-cox Sep 3, 2024

aalves08 commented Aug 22, 2024

jordojordo left a comment

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

richard-cox Sep 3, 2024

Add kubewarden spec to extension compatibility tests #11668

Are you sure you want to change the base?

Add kubewarden spec to extension compatibility tests #11668

Conversation

aalves08 commented Aug 19, 2024 • edited by jordojordo Loading

Summary

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

aalves08 commented Aug 21, 2024

richard-cox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aalves08 commented Aug 22, 2024

jordojordo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aalves08 commented Aug 19, 2024 •

edited by jordojordo

Loading