Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] Show Cloud Credential Expiration information for Harvester Creds, add actions to renew #12157

Merged
merged 6 commits into from
Oct 18, 2024
Merged

[2.10] Show Cloud Credential Expiration information for Harvester Creds, add actions to renew #12157

merged 6 commits into from
Oct 18, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 7, 2024 •
edited
Loading

Summary

Fixes #11332

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Oct 7, 2024
@richard-cox richard-cox requested a review from torchiaf October 7, 2024 11:58
@richard-cox richard-cox self-assigned this Oct 7, 2024
@richard-cox
Update & Improvement
af90846 
- Update label with latest value
- Improve fn that updates cloud cred fn
  - make it more efficient when fetching cluster
  - add consistent error handling
@richard-cox
Fix cloud cred annotation collection
a51e753 
- this magically worked before because const y = ['a']; this.x[y] --> this.['a']
- if anything else was added to the array it would fial
@richard-cox richard-cox mentioned this pull request Oct 11, 2024
Merged
7 tasks
@richard-cox richard-cox requested a review from momesgin October 11, 2024 12:47
momesgin
momesgin approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cherry picks three other PRs, one is previously reviewed by me, and the other two by Francesco, so based on that I approve this

@richard-cox richard-cox merged commit 69e1b26 into rancher:master Oct 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momesgin momesgin momesgin approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Allow users to easily see expiring harvester cloud credentials and to renew them
2 participants
@richard-cox @momesgin