Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fetch when navigating on pages that contain ResourceDetail #12237

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 11, 2024

Summary

This prevents ResourceDetail from invoking fetch() when navigating back.

This PR applies existing work performed in #11986 to shell/components/ResourceDetail/index.vue.

Fixes #12219
Fixes #12073

Occurred changes and/or fixed issues

  • add a guard to the $route.query watcher to prevent fetch from navigating when routing back

Technical notes summary

Areas or cases that should be tested

ResourceDetail involves almost every edit component in Dashboard.

Areas which could experience regressions

Routing back in for edit components of Dashboard could break.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip force-pushed the bugfix/12219-fetch-errors branch from 5b78f0f to f417bb3 Compare October 11, 2024 20:07
@rak-phillip rak-phillip changed the title Resolve fetch when navigating on pages that contain ResourceDetail Prevent fetch when navigating on pages that contain ResourceDetail Oct 11, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Oct 11, 2024
@rak-phillip rak-phillip marked this pull request as ready for review October 14, 2024 20:10
@rak-phillip rak-phillip merged commit b574979 into rancher:master Oct 14, 2024
40 checks passed
@rak-phillip rak-phillip deleted the bugfix/12219-fetch-errors branch October 14, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants