Fix fleet cattle healthcheck #12288
Merged
Fix fleet cattle healthcheck #12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalves08
approved these changes
Oct 18, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* fix cluster dashboard cattle and fleet agent healthchecks when user has limited permissions * add test for standard uesr cluster dashboard * clean up commented code * fix cluster dashboard unit test * fix cluster dashboard e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12259
Occurred changes and/or fixed issues
This PR tweaks the logic used to show fleet and cattle agent statuses on the cluster explorer dashboard. Previously we checked that the user was able to list deployments; now we check that they can see the namespace the deployments would be in.
Technical notes summary
Areas or cases that should be tested
Cluster explorer dashboard with both local and downstream clusters (local will not show cattle agent), both as admin and a user with project membership only, as outlined in #12259
Checklist