Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e test for newly created project/namespace #12362

Merged
merged 15 commits into from
Nov 26, 2024
Merged

Fix e2e test for newly created project/namespace #12362

merged 15 commits into from
Nov 26, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Oct 24, 2024 •
edited
Loading

Summary

Fixes #12338

Technical notes summary

Increasing the timeout and scrolling into view was needed to fix the test.

Areas or cases that should be tested

n/a

Areas which could experience regressions

n/a

Screenshot/Video

n/a

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.10.0 milestone Oct 24, 2024
@momesgin momesgin requested a review from richard-cox October 24, 2024 23:54
@momesgin momesgin self-assigned this Oct 24, 2024
@momesgin momesgin marked this pull request as draft October 25, 2024 01:44
richard-cox
richard-cox previously approved these changes Oct 25, 2024
View reviewed changes
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Oct 31, 2024
@momesgin momesgin marked this pull request as ready for review November 18, 2024 18:10
@momesgin momesgin requested a review from izaac November 25, 2024 19:27
eva-vashkevich
eva-vashkevich previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

izaac
izaac previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momesgin momesgin requested a review from izaac November 26, 2024 17:34
izaac
izaac approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@momesgin momesgin merged commit 687cf01 into rancher:master Nov 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

@eva-vashkevich eva-vashkevich eva-vashkevich left review comments

@richard-cox richard-cox Awaiting requested review from richard-cox

Assignees

@momesgin momesgin

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Fix namespace-picker.spec.ts e2e test failing in 2.10
5 participants
@momesgin @izaac @richard-cox @eva-vashkevich @nwmac