Add oci url to the list of acceptable urls #12421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Oct 30, 2024
| @@ -1117,6 +1117,7 @@ describe('formRules', () => { | |||
| const testCases = [ | |||
| ['', undefined], | |||
| ['https://github.com/rancher/fleet-examples.git', undefined], | |||
| ['oci://test.rancher.io/charts/mychart', undefined], | |||
There was a problem hiding this comment.
can this be expanded to cover all types defined in https://ranchermanager.docs.rancher.com/v2.9/how-to-guides/new-user-guides/helm-charts-in-rancher/oci-repositories#add-an-oci-based-helm-chart-repository
| @@ -1117,6 +1117,7 @@ describe('formRules', () => { | |||
| const testCases = [ | |||
| ['', undefined], | |||
| ['https://github.com/rancher/fleet-examples.git', undefined], | |||
| ['oci://test.rancher.io/charts/mychart', undefined], | |||
There was a problem hiding this comment.
can this be expanded to cover more url types? the regex has me scared
richard-cox
reviewed
Oct 30, 2024
| @@ -458,7 +458,7 @@ export default function(t: Translation, { key = 'Value' }: ValidationOptions): { | |||
| return runValidators(val, [startHyphen('label'), endHyphen('label'), startDot('label'), endDot('label'), required]); | |||
| }; | |||
|
|
|||
| const repo: Validator = (val) => val && !/((git|ssh|http(s)?)|(git@[\w\.]+))(\:(\/\/)?)([\w\.@\:/\-~]+)(\.git)?(\/)?/.test(val) ? t('validation.setting.repo') : undefined; | |||
| const repo: Validator = (val) => val && !/((git|ssh|oci|http(s)?)|(git@[\w\.]+))(\:(\/\/)?)([\w\.@\:/\-~]+)(\.git)?(\/)?/.test(val) ? t('validation.setting.repo') : undefined; | |||
There was a problem hiding this comment.
Tan made a good point in slack, fleet doesn't support oci for their git repo's (helm repos though do)
|
@richard-cox based on the decision to remove the repo validation for now, I'll close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
contributes to #12204
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist