Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we don't lose values on edit of cluster scan resources #12427

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Oct 30, 2024

Summary

Fixes #12411

Note: #12412 is required to fix the specific issue on that field.

Occurred changes and/or fixed issues

We were previously clearing out the spec of the resource on edit. Don't know why.

This PR updates that so that we preserve the data in the resource on edit

Areas or cases that should be tested

Test as per the issue above.

Due to time constraints, this will need manual testing.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac requested a review from aalves08 October 30, 2024 12:23
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Oct 30, 2024
@nwmac nwmac force-pushed the fix-cis-scan-edit branch from 35ee827 to acca917 Compare October 30, 2024 14:06
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a go and LGTM @nwmac
Screenshot 2024-10-30 at 14 39 08

@nwmac nwmac merged commit 6dd2962 into rancher:master Oct 30, 2024
31 checks passed
@nwmac nwmac deleted the fix-cis-scan-edit branch October 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIS Benchmark: Scans: Configurations set during creation are not reflected in edit mode
2 participants