Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed repo format validation #12431

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 30, 2024

Summary

Fixes #12204

Removing git repo format validation because we want to test the formatting more for now.
Added #12432 to add better format validation to this page.

Occurred changes and/or fixed issues

Removed format validation for the git repository input field.
Field is still marked as required.

Technical notes summary

None

Areas or cases that should be tested

Fleet -> Git repo -> Create
Repository URL field should be marked as required, but we do not test the format of the url

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich eva-vashkevich added this to the v2.10.0 milestone Oct 30, 2024
@nwmac nwmac merged commit 69fa9ec into rancher:master Oct 31, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form validation broken on GitRepo page
3 participants