Compare against both base-version and base@version #12433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owanturist
commented
Oct 30, 2024
| @@ -6,10 +6,10 @@ GITHUB_WORKFLOW_TYPE=$3 | |||
|
|
|||
| # Ensure "catalog" workflow release tag name does not match a pkg/<pkg-name> | |||
| if [[ "${GITHUB_WORKFLOW_TYPE}" == "catalog" ]]; then | |||
| for d in pkg/*/ ; do | |||
| for d in pkg/*/; do | |||
There was a problem hiding this comment.
the deleted whitespace is result of shell-format run
owanturist
commented
Oct 30, 2024
| pkg=$(basename $d) | ||
|
|
||
| PKG_VERSION=$(jq -r .version pkg/${pkg}/package.json) | ||
| PKG_VERSION=$(jq -r .version pkg/${pkg}/package.json) || exit 1 |
There was a problem hiding this comment.
chatgpt suggested that change to verify that jq returns something
jordojordo
added
area/extensions
shell
|
Not needed anymore StackVista/rancher-extension-stackstate#41 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am investigating the possibility of integrating https://github.com/semantic-release/semantic-release tool to automate versioning of https://github.com/StackVista/rancher-extension-stackstate and for that matter I wish I can use
changeset tagcommand but the caveat is that it formats the tag asname@versionand notname-versionas required by the workflow.I'd like to propose a change to match both tag formats, it should not hurt to have them simultaneously.
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist