Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit Yaml Footer's layout issue #12568

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Nov 8, 2024

Summary

Fixes #10880

Occurred changes and/or fixed issues

Technical notes summary

Removed flexContent prop that was added a long time ago but never really used. The issue wasn't limited to the Pods page, basically it was happening anywhere in the app if the yaml section was too short.

Areas or cases that should be tested

Any place that Yaml Editor is displayed.

Areas which could experience regressions

I did my best to make sure this doesn't break any pages by checking many places that the Yaml editor is displayed, but testing by a second person will be great.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Nov 8, 2024
@momesgin momesgin self-assigned this Nov 8, 2024
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
I've checked different pages that use ResourceDetail component and they seem to work as expected

@momesgin momesgin merged commit 50f7916 into rancher:master Nov 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Yaml page footer does not stick to bottom of page
2 participants