Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve E2E tests, target v2.10-head #12575

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Improve E2E tests, target v2.10-head #12575

merged 3 commits into from
Nov 11, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Nov 11, 2024 •
edited
Loading

Summary

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Nov 11, 2024
@richard-cox richard-cox self-assigned this Nov 11, 2024
@richard-cox richard-cox mentioned this pull request Nov 11, 2024
Closed
7 tasks
richard-cox and others added 2 commits November 11, 2024 09:46
@richard-cox
Improve E2E tests (rancher#12366)
6713674 
* Improve pod.spec test

* Improve another repo spec test

* vai test improvements

* Various fixes

* pagination change fixes

* pagination change fixes + new settings

* Update settings-utils.ts

* Fixes

* create name fixes

* improve namespace picker test

* Fix user response

* fixes

* fixes

* fixes

* Make up for userpreference lag by waiting for desired value

* Dont include junk revision in mock resources
- causes MASSSIVE socket spam if the rancher revision exceeds it

* update burger menu, make it clear there's pinned and other cluster lists

also comment out .skip, they play HAVOC with test reports

* improve tableRowsPerPageAndNamespaceFilter

* fix project-namespace

* more fixes...

* Revert "Dont include junk revision in mock resources"

This reverts commit 9aaaabb.

* real revision fix

* lint fixes are commenting out skip

* use common resource revision

* safer userpref check

* fix standard user tests

* more linting

* because why not

* fixes/improvements

* Add retry to updateNamespaceFilter

* improve CRD list check for count

* after own review

* tie in failure and retry to tableRowsPerPageAndNamespaceFilter

* handle events count less than 500...

* fix merge fail
@rak-phillip @richard-cox
Target v2.10-head for e2e runs
9f744ad 
Signed-off-by: Phillip Rak <[email protected]>
rak-phillip
rak-phillip approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - all these changes approved for 2.11 closely mirror 2.10 with the recent branch; the added e2e test stability will be welcome in 2.10 🙂

@richard-cox richard-cox merged commit 52aecc8 into rancher:release-2.10 Nov 11, 2024
29 checks passed
@richard-cox richard-cox deleted the flakey-test-2.10 branch November 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonasberhe23 yonasberhe23 yonasberhe23 approved these changes

@rak-phillip rak-phillip rak-phillip approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @rak-phillip @yonasberhe23