Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation: add step to ensure aks is enabled #13113

Merged
merged 1 commit into from
Jan 18, 2025
Merged

automation: add step to ensure aks is enabled #13113

merged 1 commit into from
Jan 18, 2025

Conversation

yonasberhe23
Copy link
Contributor

Summary

Fixes #rancher/qa-tasks#1638

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.11.0 milestone Jan 14, 2025
@yonasberhe23 yonasberhe23 requested a review from izaac January 14, 2025 22:35
@yonasberhe23 yonasberhe23 self-assigned this Jan 14, 2025
@yonasberhe23 yonasberhe23 force-pushed the aks_test_clean_up branch 2 times, most recently from eff5ce8 to 312c200 Compare January 16, 2025 19:19
@izaac izaac requested a review from IsaSih January 16, 2025 19:22
@izaac
Copy link
Contributor

izaac commented Jan 16, 2025

@IsaSih could you take a look at this too? 👍🏽

@yonasberhe23 yonasberhe23 requested a review from IsaSih January 16, 2025 23:05
izaac
izaac previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 requested a review from IsaSih January 17, 2025 23:28
izaac
izaac previously approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 requested a review from IsaSih January 18, 2025 02:32
izaac
izaac approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 merged commit b5d7018 into rancher:master Jan 18, 2025
32 checks passed
@yonasberhe23 yonasberhe23 deleted the aks_test_clean_up branch January 19, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaSih IsaSih IsaSih approved these changes

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
area/e2e
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yonasberhe23 @izaac @IsaSih