Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LabeledSelect not emitting search explicitly #13142

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Jan 16, 2025

Summary

LabeledSelect wasn't explicitly emitting search event.

Occurred changes and/or fixed issues

Added an explicit search event. It should be working as before.

Technical notes summary

Areas or cases that should be tested

Search should work in anything that uses SelectPrincipal :

  • Cluster member editor (Cluster and Project Members -> Cluster membership -> Add),
  • Project member editor (Cluster and Project Members -> Project membership -> Add) ,
  • Configuring any auth provider (github, azuread, etc)
    or GitPicker (not used in dashboard code)

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich eva-vashkevich self-assigned this Jan 16, 2025
@eva-vashkevich eva-vashkevich added this to the v2.11.0 milestone Jan 16, 2025
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit beef20e into rancher:master Jan 17, 2025
46 of 47 checks passed
@eva-vashkevich eva-vashkevich deleted the labeled_select_search branch January 17, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants