Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pagination settings (almost) ready for production #13159

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

Summary

Fixes #13089

Occurred changes and/or fixed issues

  • Previously the ui-performance object ssp object contained a required set of resources to apply ssp to
  • This isn't workable going forward where the available resources will be updated between versions
  • Now the default is to use a the inbuilt default resources which can change between versions
  • Users can override if they wish (for preference OR in case of bugs)

Areas or cases that should be tested

  • Fresh system (or with /v3/settings/ui-performance value set to an empty string). No pagination anywhere
  • Check SSP on, no other changes. Pagination on for places like the home page
  • When running in dev, in performance page, use the defaults button and enable SSP to populate the resources with default. Pagination on for places like the home page. Tweak the resources (store object) like changing the context of the prov cluster to not include home (like homeaaa`). Pagination on home page should not be on

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- 'almost' applies to enabling SSP by default
- Previously the ui-performance object contained a required set of resources to apply SSP to
- This isn't workable going forward where the available resources will be updated between versions
- Now the default is to use a set of default resources which can change between versions
- Users can override if they wish
@richard-cox richard-cox added this to the v2.11.0 milestone Jan 20, 2025
@richard-cox richard-cox self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server-side Pagination: Tidy up settings
1 participant