Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key nav on preferences page #13161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

Summary

Fixes #12791

Occurred changes and/or fixed issues

Technical notes summary

  • Fixes keyboard navigation on the user preferences page
  • Fixes Select component implementation so that it opens on enter/space and not open just on focus
  • Fixes LabeledSelect component implementation so that it opens on enter/space and not open just on focus
  • Fixes ButtonGroup so that is keyboard navigable
  • Fixes RadioGroup and RadioButton so that is keyboard navigable

Areas or cases that should be tested

Areas which could experience regressions

  • Test LabeledSelect's and Select's thoroughly throughout the UI, especially more "exotic" implementations. Basic use case should be covered.

Screenshot/Video

Screen.Recording.2025-01-20.at.16.30.43.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.11.0 milestone Jan 20, 2025
@aalves08 aalves08 self-assigned this Jan 20, 2025
@aalves08 aalves08 requested a review from rak-phillip January 20, 2025 16:36
rak-phillip
rak-phillip previously approved these changes Jan 21, 2025
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shell/assets/styles/base/_mixins.scss Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation, aria-label, role and focus display for user preferences screen
2 participants