Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport PR 12886 - improvement Tabs extension point #13179

Open
wants to merge 4 commits into
base: release-2.9
Choose a base branch
from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 22, 2025

Summary

Fixes #13166

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Check repro steps on original PR #12886

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 requested a review from jordojordo January 22, 2025 14:09
@aalves08 aalves08 self-assigned this Jan 22, 2025
@aalves08
Copy link
Member Author

@jordojordo If you think there's any relevant change on this PR that wasn't on my PR proposal, we might need to add it to master as well since I "copied" the original PR and tested it, so any change you do won't be reflected on master 🙏

@jordojordo
Copy link
Member

jordojordo commented Jan 31, 2025

@aalves08 That's fine with me, I was just testing to see if updating the actions/upload-artifact version would fix the gates. I see you added those updates to both of these 2.9 and 2.8 PRs, we should probably do this in master as well.

As for the change in fleet.catalog.cattle.io.gitrepo.vue, the unmounted hook is specific to Vue 3, beforeDestroy or destroyed would be the Vue 2 equivalent. I don't believe we would need to forward port this, and I'm not even sure if this is necessary, I was mostly testing to see if the gates passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants