Match Harvester community repo check via regex #13206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to #13199
Occurred changes and/or fixed issues
Technical notes summary
Non-Prime users will use the community repository when manually installing Harvester. We are adding some Regex strings to match the Harvester community repository url, so that it can be one of:
https://github.com/harvester/harvester-ui-extension
https://github.com/harvester/harvester-ui-extension/
https://github.com/{forker-repository}/harvester-ui-extension
https://github.com/{forker-repository}/harvester-ui-extension/
https://harvester.github.io/harvester-ui-extension
Prime users will always use
https://github.com/rancher/ui-plugin-charts
, so nothing to do for this case.Areas or cases that should be tested
Instead of installing Harvester extension from Virtualization Management Page -> Install button, manually add the Harvester repository from 'Repositories' page and install Harvester from 'Extensions' page, see issue's description or steps below.
Add Harvester repository using one of url/branch below:
https://github.com/harvester/harvester-ui-extension
-gh-pages
https://github.com/harvester/harvester-ui-extension/
-gh-pages
https://github.com/{forker-repository}/harvester-ui-extension
-gh-pages
https://github.com/{forker-repository}/harvester-ui-extension/
-gh-pages
https://harvester.github.io/harvester-ui-extension
- no branch, this is the GitHub deployment UrlInstall Harvester
Verify that Virtualization Management page doesn't show Missing Repository error
Areas which could experience regressions
Install and Update Button
Screenshot/Video
Checklist