Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove close button from banner and move to a page action #13255

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jan 31, 2025

Summary

Fixes #13251

Occurred changes and/or fixed issues

This PR modifies the UI slightly to avoid the issue with keyboard navigation on the banner close icon.

The banner can now be shown/hidden by the page action menu - this feels like a better fit.

PR adds an e2e test to cover the change.

Restore hidden cards now only restores the what's new and login preference banner visibility.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac marked this pull request as ready for review February 6, 2025 14:22
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.11.0 milestone Feb 6, 2025
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - functions well, and I only have a few optional comments to consider.

shell/assets/translations/en-us.yaml Show resolved Hide resolved
shell/components/BannerGraphic.vue Show resolved Hide resolved
shell/config/page-actions.js Show resolved Hide resolved
cypress/e2e/tests/pages/generic/home.spec.ts Show resolved Hide resolved
@nwmac nwmac merged commit 90d0fff into rancher:master Feb 7, 2025
34 checks passed
@nwmac nwmac deleted the fix-banner-close branch February 7, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button for home page banner is not accessible with keyboard navigation
2 participants