Improve static network config #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
✅ Deploy Preview for elemental-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
improve_static_network_config
branch
from
757562f to
c6e39f4
Compare
Co-authored-by: Francesco Giudici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435
This PR improves the documentation regarding static network configuration to make it as explicit as possible.
The example now includes a nmc ready custom OS image, and instructions on how to build the ISO image.
This is a bit redundant with already existing docs, but it is used to reinforce the distinction between OS and ISO images, to indicate that custom OS images with the desired config need to be maintained and published for upgrades as well.
Most importantly, this already backports the nm-configurator based documentation to 1.6 version, since it is already viable and does not require any feature from 1.7.