Check for duplicate names for NodePools #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mjura
force-pushed
the
main-check-duplication
branch
from
1a6e7d3 to
68cdbe8
Compare
|
As mentioned in #203 (comment), should we validate that names are not null? |
richardcase
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Same comment as @salasberryfin , do we need to validation that name is not empty?
mjura
force-pushed
the
main-check-duplication
branch
from
68cdbe8 to
d02e496
Compare
richardcase
approved these changes
Oct 26, 2023
mjura
force-pushed
the
main-check-duplication
branch
from
d02e496 to
91d18bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #122
cc: @rancher/highlander