Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test workflow for CI #255

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Jan 5, 2024

What this PR does / why we need it:
We want to run unit tests.

Which issue(s) this PR fixes
Issue ##93

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@mjura mjura requested a review from a team as a code owner January 5, 2024 08:18
@mjura mjura mentioned this pull request Jan 5, 2024
1 task
pull_request:
push:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
- master
- main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, it seems that it has to be changed everywhere!! Good catch @richardcase

@mjura mjura force-pushed the unit-tests-workflow branch from 41e75fe to be01305 Compare January 5, 2024 10:58
@mbologna
Copy link
Member

mbologna commented Jan 5, 2024

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

Approving even if the checklist is not completed yet

@mjura mjura merged commit 25ff40b into rancher:main Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants