Fix e2e daily tests #263
Merged
Fix e2e daily tests #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
e2e-fix
branch
from
4fcbda0 to
c6d2294
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
salasberryfin
approved these changes
Jan 10, 2024
mjura
approved these changes
Jan 10, 2024
Danil-Grigorev
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
e2e tests locally are passing since the user is expected to change the
projectIDvalue in theGKEClusterConfigcluster template. However, e2e tests running daily in the GitHub Actions also need to replace that value, hence it was missing till now. This PR ensures the newGKE_PROJECT_IDvar is created and passed to the cluster template later and replaces it with the actual value from GH secretGKE_PROJECT_ID. This should fix e2e tests currently brokenhttps://github.com/rancher/gke-operator/actions/workflows/e2e-latest-rancher.yaml
Which issue(s) this PR fixes
Fixes: #264
Follow-up to: #256
Special notes for your reviewer:
Tested the changes in my fork and tests are passing: https://github.com/furkatgofurov7/gke-operator/actions/runs/7472680816
Checklist: