Add support for Customer Managed Encryption Key #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjura
force-pushed
the
bootDiskKmsKey
branch
from
a962ace to
1d840f4
Compare
richardcase
reviewed
Feb 16, 2024
mjura
force-pushed
the
bootDiskKmsKey
branch
2 times, most recently
from
24a9f17 to
53dede0
Compare
mjura
changed the title
salasberryfin
previously approved these changes
Feb 19, 2024
furkatgofurov7
previously approved these changes
Feb 19, 2024
5 tasks
Add support for The Customer Managed Encryption Key used to encrypt the boot disk attached to each node in the node pool. For more information about protecting resources with Cloud KMS Keys please see: https://cloud.google.com/compute/docs/disks/customer-managed-encryption Issue: rancher#261
mjura
dismissed stale reviews from furkatgofurov7 and salasberryfin
via
b2e3d2c
mjura
force-pushed
the
bootDiskKmsKey
branch
from
53dede0 to
b2e3d2c
Compare
salasberryfin
approved these changes
Feb 20, 2024
|
Sorry for late reply, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for The Customer Managed Encryption Key used to encrypt the boot disk attached to each node in the node pool.
For more information about protecting resources with Cloud KMS Keys please see:
https://cloud.google.com/compute/docs/disks/customer-managed-encryption
Which issue(s) this PR fixes
Issue: #261
Special notes for your reviewer:
Checklist: