Fix AKS failure #234
Merged
Fix AKS failure #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parthvi Vala <[email protected]>
cpinjani
reviewed
Jan 9, 2025
hosted/aks/helper/helper_cluster.go
Outdated
|
|
||
| out, err := proc.RunW("az", rgargs...) | ||
| if err != nil { | ||
| return errors.Wrap(err, "Failed to create cluster: "+out) |
There was a problem hiding this comment.
Suggested change
| return errors.Wrap(err, "Failed to create cluster: "+out) | |
| return errors.Wrap(err, "Failed to create resource group: "+out) |
cpinjani
reviewed
Jan 9, 2025
| AfterEach(func() { | ||
| if ctx.ClusterCleanup && (cluster != nil && cluster.ID != "") { | ||
| GinkgoLogr.Info(fmt.Sprintf("Cleaning up resources %s %s", cluster.Name, cluster.ID)) |
There was a problem hiding this comment.
Suggested change
| GinkgoLogr.Info(fmt.Sprintf("Cleaning up resources %s %s", cluster.Name, cluster.ID)) | |
| GinkgoLogr.Info(fmt.Sprintf("Cleaning up resources, cluster: %s %s", cluster.Name, cluster.ID)) |
cpinjani
approved these changes
Jan 9, 2025
Co-authored-by: Parthvi Vala <[email protected]> Co-authored-by: Chandan Pinjani <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #192
Checklist:
Special notes for your reviewer: