Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup DockerFile warning annotations #54

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

mgfritch
Copy link
Contributor

See also: #53

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Signed-off-by: Michael Fritch <[email protected]>
…d can have unexpected results if the base image changes

WorkdirRelativePath: Relative workdir "sriov-network-device-plugin" can have unexpected results if the base image changes
More info: https://docs.docker.com/go/dockerfile/rule/workdir-relative-path/

Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch merged commit 3e233e2 into rancher:main Nov 14, 2024
3 checks passed
@mgfritch mgfritch deleted the dockerfile-warn branch November 14, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants