Fix tracing checklist Update Config button link #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracing page does not detect that tracing is enabled, it always shows Screencast.from.2023-10-29.18-27-18.webm |
|
This should be fixed, I was previously checking the controller chart rather than the controller app resource. tracing-tab.mp4 |
|
The e2e tests are failing since this commit was reverted. The wording for the save button has changed but will not be reflected in other tests until 1.3.0 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #529
This fixes the Tracing Checklist link to update the kubewarden-controller chart by passing in the controller's app resource instead of the chart. Also updated the wording from "Update Chart" to "Update Config" to be consistent with the Metrics Checklist.
tracing-tab.mp4