Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jenkins/jenkins package #1067

Merged

Conversation

adamkpickering
Copy link
Collaborator

@adamkpickering adamkpickering commented Sep 30, 2024

The jenkins/jenkins package does not meet the criteria for inclusion into the partner charts repository. Specifically, it is not provided by a SUSE "Ready" Verified partner. Accordingly I am deprecating it according to the deprecation and removal policy.

Users should get Jenkins directly from the official repository as described here.

It is expected that CI fails for this PR. This is because CI checks that we do not modify released .tgz files. This is an old design that no longer applies. A work item for overhauling this is present and should be worked on in the near future. Please disregard the CI failure.

A note about the changes in this PR:

  • The chart version tarball files must be modified because we are adding deprecated: true to the Chart.yaml file in each chart version.
  • The fields in the upstream.yaml file are reordered because partner-charts-ci deprecate does not retain the order of fields when it loads this file. The YAML library that partner-charts-ci uses to write the file orders fields alphabetically, leading to the change.

@adamkpickering adamkpickering requested a review from a team as a code owner September 30, 2024 19:20
@recena
Copy link
Collaborator

recena commented Oct 4, 2024

@adamkpickering Can you address the conflict?

@adamkpickering
Copy link
Collaborator Author

@recena done.

@diogoasouza
Copy link

Ci is failing @adamkpickering

@adamkpickering
Copy link
Collaborator Author

@diogoasouza it is expected that CI will fail, since we are modifying existing chart versions, and partner-charts-ci validate fails when that is the case. This is not consistent with the design of other partner-charts-ci subcommands, and I plan on addressing this in the near future.

@adamkpickering adamkpickering merged commit e3060d5 into rancher:main-source Oct 4, 2024
1 check failed
@adamkpickering adamkpickering deleted the deprecate-jenkins branch October 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants