Update for 1.20 and 1.23 scans #209

mitulshah-suse · 2022-09-19T13:43:26Z

Related to #34

btat

The sidebar.js file at the root needs to be updated as well to account for the page additions, removals, and rename(s) . I can't make suggestions or comment on it since it's not part of the PR so I added a commit for the sidebar.js file.

It also looks like PDFs haven't been uploaded yet. Could you please link the tickets where that's being tracked so we can keep an eye on that.

...ncher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.6-benchmark.md

...cher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.20-benchmark.md

...ecurity/rancher-v2.6-hardening-guides/rke2-self-assessment-guide-with-cis-v1.23-benchmark.md

...ecurity/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.20-benchmark.md

...ecurity/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.23-benchmark.md

...security/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.6-benchmark.md

...ecurity/rancher-v2.6-hardening-guides/rke2-self-assessment-guide-with-cis-v1.23-benchmark.md

mitulshah-suse · 2022-09-20T11:42:36Z

Issue for PDFs upload
https://github.com/rancherlabs/eio/issues/1319

btat · 2022-09-20T16:39:36Z

LGTM (docs perspective). Will merge once the PDFs are uploaded and QA has reviewed.

btat · 2022-09-22T18:01:10Z

Hi @prachidamle, who would be the QA contact to review this?

macedogm · 2022-09-23T12:00:28Z

Besides QA, these changes also need to be reviewed by security.

@btat can you please assign me as a reviewer? I can't do that myself.

prachidamle · 2022-09-27T16:11:02Z

@bmdepesa Could you assign this to someone in QA for reviewing the CIS doc changes, as requested above by @btat

ronhorton

https://releases.rancher.com/documents/security/2.6/Rancher_RKE2_v2-6_CIS_v1-23_Hardening_Guide.pdf leads to an xml error page -

NoSuchKey
The specified key does not exist.

ronhorton

missing link not uploaded as of test

prachidamle · 2022-09-29T23:43:29Z

@btat @mitulshah-suse I think the hardening and self-assessment guide should be linked to docs links internally - why do we need to upload them separately?

mitulshah-suse · 2022-09-30T05:05:03Z

@btat @mitulshah-suse I think the hardening and self-assessment guide should be linked to docs links internally - why do we need to upload them separately?

The internal links are already in place. Not sure why they are uploaded as well to be honest. I just followed the steps from an older ticket to raise the upload issue.

btat · 2022-09-30T17:22:54Z

@btat @mitulshah-suse I think the hardening and self-assessment guide should be linked to docs links internally - why do we need to upload them separately?

The internal links are already in place. Not sure why they are uploaded as well to be honest. I just followed the steps from an older ticket to raise the upload issue.

Like Mitul, I'm just following the existing process. I dug back and found https://github.com/rancher/docs/issues/1157, which would suggest the PDFs existed before the Markdown version was added to the docs site. Perhaps the PDFs are distributed directly through other means outside of the docs? @catherineluse do you have any background knowledge on this?

catherineluse · 2022-10-01T04:26:36Z

@btat Yes, Nelson generated the hardening guides in PDF format. I don't know where the source code or script is for that. Maybe Lucas knows.

macedogm · 2022-10-05T07:22:26Z

@catherineluse @btat the scripts used to convert the scans from JSON to Markdown and the Markdown pages to PDF are available in https://github.com/rancher/docs/tree/master/scripts/converters. I took over Nelson's work with the hardening guides since we updated them to 2.6. After some thinking and while creating the K3s hardening guide for GA - rancher/rancher#37493, I would actually recommend to stop generating the PDFs. As the pages grew bigger and bigger and with some small changes in formatting after the migration to Docusaurus, I see that sometimes the PDFs doesn't look great and require changes in the format. I'm not even sure if the PDFs are adding any real value to the users (at least that I'm aware of). Perhaps it's better to stop generating until customers ask for it (in case they even do). Not sure if we need to get someone from Product for this decision.

macedogm · 2022-10-05T07:27:37Z

FYI I haven't had time to review the updated guides and how they will be structured inside the security section. I plan to do this as soon as I finish some priority work for 2.6 and 2.7.

btat · 2022-12-05T17:43:54Z

@macedogm could you please review this when you have a chance.

macedogm · 2023-03-07T20:19:54Z

@btat based on #453 and #478, I believe that we can close this PR as superseded.

btat · 2023-03-07T21:22:25Z

@btat based on #453 and #478, I believe that we can close this PR as superseded.

@macedogm since the tests in this PR are for Rancher 2.6, aren't they still applicable to the 2.6 docs?

macedogm · 2023-03-08T12:40:43Z

@btat based on #453 and #478, I believe that we can close this PR as superseded.

@macedogm since the tests in this PR are for Rancher 2.6, aren't they still applicable to the 2.6 docs?

You are right. This is scoped to 2.6. It's still relevant.

macedogm · 2023-07-04T14:15:39Z

Reassigning this PR to @andypitcher who is taking the lead with the hardening guides and CIS.

Andy, if you need any support, please let me know. Thanks!

andypitcher · 2023-08-25T10:49:29Z

docs/pages-for-subheaders/rancher-v2.6-hardening-guides.md

-| Kubernetes v1.18 up to v1.23 | CIS v1.6 | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.6-benchmark.md) | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.6-benchmark.md) |
+| Kubernetes v1.18 | CIS v1.6 | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.6-benchmark.md) | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.6-benchmark.md) |
+| Kubernetes v1.19 up to v1.21 | CIS v1.20 | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.20-benchmark.md) | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.20-benchmark.md) |
+| Kubernetes v1.22 up to v1.24 | CIS v1.23 | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-self-assessment-guide-with-cis-v1.23-benchmark.md) | [Link](../reference-guides/rancher-security/rancher-v2.6-hardening-guides/rke1-hardening-guide-with-cis-v1.23-benchmark.md) |


With the dev of CIS-1.24 (k8s v1.24) and CIS-1.7 (k8s v1.25), I suggest to update L36 to have CIS-1.23 covering up to k8s v1.23:

- Kubernetes v1.22 up to v1.24 + Kubernetes v1.22 up to v1.23

andypitcher

LGTM, we will update this page when CIS-1.24 and CIS-1.7 docs will be achieved.

udpate for 1.20 and 1.23 scans

237db9b

prachidamle requested a review from btat September 19, 2022 17:02

btat requested changes Sep 19, 2022

View reviewed changes

Update sidebar

ada8a14

btat force-pushed the main branch from 7bf87ae to ada8a14 Compare September 19, 2022 22:14

missed changes

bd4d945

mitulshah-suse requested a review from btat September 20, 2022 11:42

btat approved these changes Sep 20, 2022

View reviewed changes

btat changed the title ~~udpate for 1.20 and 1.23 scans~~ Update for 1.20 and 1.23 scans Sep 20, 2022

btat added the Waiting for QA/verification label Sep 23, 2022

sowmyav27 requested a review from macedogm September 23, 2022 14:33

prachidamle requested a review from bmdepesa September 27, 2022 16:09

ronhorton suggested changes Sep 28, 2022

View reviewed changes

ronhorton approved these changes Sep 28, 2022

View reviewed changes

macedogm mentioned this pull request Oct 5, 2022

Add K3s provisioned hardening guide for Rancher v2.7 #244

Merged

martyav mentioned this pull request Mar 31, 2023

#77 Addressing backlog issue about registered AKS clusters #518

Merged

macedogm requested review from andypitcher and removed request for macedogm July 4, 2023 14:16

andypitcher reviewed Aug 25, 2023

View reviewed changes

andypitcher approved these changes Aug 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for 1.20 and 1.23 scans #209

Update for 1.20 and 1.23 scans #209

mitulshah-suse commented Sep 19, 2022

btat left a comment

mitulshah-suse commented Sep 20, 2022

btat commented Sep 20, 2022 •

edited

Loading

btat commented Sep 22, 2022

macedogm commented Sep 23, 2022 •

edited

Loading

prachidamle commented Sep 27, 2022

ronhorton left a comment

ronhorton left a comment

prachidamle commented Sep 29, 2022

mitulshah-suse commented Sep 30, 2022

btat commented Sep 30, 2022

catherineluse commented Oct 1, 2022

macedogm commented Oct 5, 2022 •

edited

Loading

macedogm commented Oct 5, 2022

btat commented Dec 5, 2022

macedogm commented Mar 7, 2023

btat commented Mar 7, 2023

macedogm commented Mar 8, 2023

macedogm commented Jul 4, 2023

andypitcher Aug 25, 2023

andypitcher left a comment

Update for 1.20 and 1.23 scans #209

Are you sure you want to change the base?

Update for 1.20 and 1.23 scans #209

Conversation

mitulshah-suse commented Sep 19, 2022

btat left a comment

Choose a reason for hiding this comment

mitulshah-suse commented Sep 20, 2022

btat commented Sep 20, 2022 • edited Loading

btat commented Sep 22, 2022

macedogm commented Sep 23, 2022 • edited Loading

prachidamle commented Sep 27, 2022

ronhorton left a comment

Choose a reason for hiding this comment

ronhorton left a comment

Choose a reason for hiding this comment

prachidamle commented Sep 29, 2022

mitulshah-suse commented Sep 30, 2022

btat commented Sep 30, 2022

catherineluse commented Oct 1, 2022

macedogm commented Oct 5, 2022 • edited Loading

macedogm commented Oct 5, 2022

btat commented Dec 5, 2022

macedogm commented Mar 7, 2023

btat commented Mar 7, 2023

macedogm commented Mar 8, 2023

macedogm commented Jul 4, 2023

andypitcher Aug 25, 2023

Choose a reason for hiding this comment

andypitcher left a comment

Choose a reason for hiding this comment

btat commented Sep 20, 2022 •

edited

Loading

macedogm commented Sep 23, 2022 •

edited

Loading

macedogm commented Oct 5, 2022 •

edited

Loading