Add integration tests for steve OR and NOT filters #40586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmurphy
changed the title
cmurphy
changed the title
cmurphy
force-pushed
the
steve-or-filter
branch
from
c89af15 to
f0f7adb
Compare
cmurphy
force-pushed
the
steve-or-filter
branch
from
f0f7adb to
103308a
Compare
KevinJoiner
previously approved these changes
Mar 31, 2023
igomez06
previously approved these changes
Mar 31, 2023
|
@igomez06 correct, this is 2.7-only |
cmurphy
force-pushed
the
steve-or-filter
branch
from
103308a to
a1705f3
Compare
|
Rebased. Had to add elements of #40536 here to run integration tests on local, I misinterpreted #40310 (comment) and it turns out that causes output.csv to be overwritten with an empty file, which we don't want. |
igomez06
previously approved these changes
Apr 17, 2023
|
Good point, yes can do |
cmurphy
force-pushed
the
steve-or-filter
branch
from
a1705f3 to
05b3497
Compare
|
I split the local/downstream addition into a separate commit so I could backport it. Also added a commit to make the output testing more flexible, since @rmweir pointed out these don't work on k8s 1.23. |
KevinJoiner
previously approved these changes
May 4, 2023
The behavior on local vs downstream can sometimes be subtly different, so it is worth running API tests on both. Also, the steveapi tests are self-documenting, but they were not writing their outputs because their outputs were different from run to run because the downstream cluster ID was different. This change ensures both sets of tests are run but the output examples are only recorded when the output is deterministic (which is for the local).
The steveapi integration tests try to be precise about the desired output of API calls. This was causing a problem when run on k8s 1.23 which has default token secrets in every namespace and so was adding extra resources to the response output. This change adds a label to the secrets created in TestList so that they can easily be identified on a live cluster and so unlabeled secrets can be ignored.
|
had to rebase |
KevinJoiner
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #40141
Depends on rancher/steve#76
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations