Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go version to 1.22 #39

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

FrankYang0529
Copy link
Collaborator

Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

Could we add more info about why we remove the validate-ci?
(On the corresponding commit)

Currently, rancherd doesn't use any `go generate`, so we don't need
validate-ci. Also, go 1.22 shows `no Go files ...` when running `go
generate`.

Signed-off-by: PoAn Yang <[email protected]>
@FrankYang0529
Copy link
Collaborator Author

Could we add more info about why we remove the validate-ci?
(On the corresponding commit)

Yes, updated it. Thanks.

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@FrankYang0529 FrankYang0529 merged commit bee45cd into rancher:harvester-dev Jul 16, 2024
1 check passed
@FrankYang0529 FrankYang0529 deleted the HARV-6160 branch July 16, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants