Use data-dir and wal-dir to restore etcd snapshots

[Zebradil]

#2547

[superseb]

Thanks, will take a look

[Zebradil]

Got some time to take a look this?

[Zebradil]

@superseb is there a chance this will be merged?

[superseb]

Can you make it 1 commit? And the only question I have on this why we are moving away from mv and now are using cp while we are still moving files around but just in subdirectories.

[superseb]

^^

[Zebradil]

Thanks for taking a look on this.

I don't remember already, why mv got changed to cp. There was a reason for that most likely. I'll check a version with mv to see why it didn't work.

[Zebradil]

@superseb sorry, just managed to get to this topic.

I replaced cp back to mv and also fixed another issue, which happens when old WAL files are not deleted. In this case etcd fails with error: "etcdmain: wal: crc mismatch". And squashed this to a single commit.

[Zebradil]

@superseb Any chance to have another look on that?

[superseb]

@Zebradil CI is failing

[Zebradil]

@superseb I fixed formatting and squashed commits again. Now there is another error in CI, which doesn't seem actionable for me.

[superseb]

@Zebradil Can you create a new PR against release/v1.3 so Drone picks it up for proper CI? Then I can merge it.

[Zebradil]

@superseb done

[Zebradil]

This is ridiculous, I'm tired updating my branch and resolving conflicts.