Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backup_restore.md #321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update backup_restore.md #321

wants to merge 1 commit into from

Conversation

Tejeev
Copy link
Contributor

@Tejeev Tejeev commented Jan 31, 2025

Can't count how many times we've seen removing backup etcd dbs put a customer in a bad spot.

@Tejeev Tejeev requested a review from a team as a code owner January 31, 2025 19:35
@@ -52,9 +52,13 @@ rke2 server \
systemctl start rke2-server
```

4. Remove the rke2 db directory on the other server nodes as follows:
4. Move the rke2 db directory on the other server nodes as follows (you want to keep a copy to avoid ending up with only an old or corrupt backup to chose for):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the old DB dir around on the secondary servers doesn't really help with anything. If you run into problems, restoring a snapshot is a better resolution than moving an old db dir back into place.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that we currently run rm -rf /var/lib/rancher/rke2/server/db/, which deletes both the etcd data and the snapshots directory. This means we erase the live data along with its backups.

We've encountered cases where customers, not paying close attention, have accidentally executed this command on all three master/etcd nodes, leading to complete data loss.

This change ensures that snapshots are not deleted until the cluster has been fully restored, allowing customers to perform the cleanup on their own afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants