Index more sqlite cache fields #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbolotSuse
suggested changes
Sep 3, 2024
MbolotSuse
suggested changes
Sep 4, 2024
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
5ca4081 to
67c463f
Compare
|
I figured out the other fields, except I'm not sure if the events should go in the empty-string group or in group |
MbolotSuse
suggested changes
Sep 5, 2024
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
2 times, most recently
from
cf9dd7e to
b97d575
Compare
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
494b7ea to
5e3de28
Compare
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
5e3de28 to
8eb3632
Compare
MbolotSuse
suggested changes
Sep 24, 2024
MbolotSuse
previously requested changes
Sep 25, 2024
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
88f64b9 to
eb55ceb
Compare
ericpromislow
dismissed
MbolotSuse’s stale review
I implemented the requested changes
moio
reviewed
Sep 27, 2024
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
eb55ceb to
c9e8789
Compare
moio
reviewed
Oct 10, 2024
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
99fb430 to
f226a31
Compare
Misc changes: - Use the builtin Event class, not events.k8s.io (by looking at the dashboard client code) - Specify full path to the management.cattle.io fields. - Map `Event.type` to `Event._type` for indexing. Use a compound transform-func to first check for a "signal", and then to run all the relevant transformers until either one fails or the list is exhausted. - Includes moving the fakeSummaryCache type into a common area. Use a simpler way of running transforms.
ericpromislow
force-pushed
the
46642-index-more-sqlite-cache-fields
branch
from
c3ec254 to
44c7f7a
Compare
MbolotSuse
approved these changes
Oct 17, 2024
| ) | ||
|
|
||
| func TestTransformEvents(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Needs a test case where there's no "type" and so we don't add "_type".
Comment on lines
+31
to
+35
| converters := make([]func(*unstructured.Unstructured) (*unstructured.Unstructured, error), 0) | ||
| if gvk.Kind == "Event" && gvk.Group == "" && gvk.Version == "v1" { | ||
| converters = append(converters, events.TransformEventObject) | ||
| } | ||
| converters = append(converters, t.defaultFields.TransformCommon) |
There was a problem hiding this comment.
Nit: You could initialize this with the common converter:
Suggested change
| converters := make([]func(*unstructured.Unstructured) (*unstructured.Unstructured, error), 0) | |
| if gvk.Kind == "Event" && gvk.Group == "" && gvk.Version == "v1" { | |
| converters = append(converters, events.TransformEventObject) | |
| } | |
| converters = append(converters, t.defaultFields.TransformCommon) | |
| converters := []func(*unstructured.Unstructured) (*unstructured.Unstructured, error){t.defaultFields.TransformCommon} | |
| if gvk.Kind == "Event" && gvk.Group == "" && gvk.Version == "v1" { | |
| converters = append(converters, events.TransformEventObject) | |
| } |
There was a problem hiding this comment.
I'd rather leave the transformers running from specific to general, until we find they can be run in any order.
Comment on lines
+187
to
+189
| raw, isSignal, err := common.GetUnstructured(test.input) | ||
| require.False(t, isSignal) | ||
| require.Nil(t, err) |
There was a problem hiding this comment.
Nit: I'm not sure that this should be part of this set of tests. The GetUnstructured call is part of the implementation detail of the Transform function - not something that is directly part of this package.
5 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #46642
I don't see a straightforward way to test this