Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release v2.9] Adding Group, Version, Kind in Update proxy_store.go #282

Merged
merged 2 commits into from
Sep 26, 2024
Merged

[Release v2.9] Adding Group, Version, Kind in Update proxy_store.go #282

merged 2 commits into from
Sep 26, 2024

Conversation

gehrkefc
Copy link
Contributor

This is a backport of this PR into Release v2.9

This is related to rancher/rancher issue: 42823

@gehrkefc gehrkefc requested a review from a team as a code owner September 16, 2024 23:14
ericpromislow
ericpromislow requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an instance of fmt.Errorf(STRCONST) in pkg/stores/partition/store.go that should be replaced with a errors.New(...) but otherwise it's fine.

ericpromislow
ericpromislow approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gehrkefc gehrkefc merged commit aacb5b8 into release/v2.9 Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

@tomleb tomleb tomleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gehrkefc @ericpromislow @tomleb @prachidamle