refactor(accesscontrol): control concurrent access to AccessStore cache #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
force-pushed
the
concurrent-AccessFor-fix
branch
from
938078a to
31cbd3f
Compare
|
Thanks for the prompt review @tomleb @ericpromislow! |
aruiz14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#47318
Depends/stacked on #286
Uses
singleflightto aggregate every concurrent calls toAccessForfor the same user. Unlike a regular mutex, this sync mechanism allows to control by key and ensures concurrent calls with the same key will all wait for the first one to complete, returning the same value for all of them.