Fix overriding update and remove links with the wrong link #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericpromislow Was there a reason to override those links? I see they are set conditionally in apiserver. Is there a case where they wouldn't be allowed in apiserver (so no links) but allowed in steve -> would result in no links? |
bigkevmcd
approved these changes
Jan 15, 2025
So Michael B walked me through his solution for a problem which turned into steve PR 308, which just incorporated the AccessSetLookup, but I don't have enough context to tell you what the reason was, nor what's going on in the apiserver. |
ericpromislow
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #308 we were not overriding the update / remove links, so they were pointing to the right path (
/v1/...). The new code was now overriding those links but to the wrong path (/api/...or/apis/...) which points to the native k8s resource. This caused issue in the UI.The fix is to not override the links that already exist, we either block or delete them.