-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add provider section with examples #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you remove "fixes # 81"? We will need to add RKE2+EC2 based later when CAPA release is done #117.
1a19afa
to
14df9fd
Compare
Thanks @alexander-demicev. Rebased PR and addressed suggestions. |
Signed-off-by: Carlos Salas <[email protected]>
14df9fd
to
dd196a8
Compare
Thanks for the review @yiannistri. The PR is now updated and ready to be reviewed again. |
Thanks @furkatgofurov7 @yiannistri. I merged CAPI Providers guides into a single page and used tabs for some steps while keeping the common parts (like cluster/namespace import). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @salasberryfin LGTM, one small suggestion
Signed-off-by: Carlos Salas <[email protected]>
67d28f8
to
79e9976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @salasberryfin 👍 Just one tiny suggestion to keep things consistent.
> cluster1.yaml | ||
``` | ||
|
||
2. View **cluster1.yaml** to ensure there are no tokens. You can make any changes you want as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. View **cluster1.yaml** to ensure there are no tokens. You can make any changes you want as well. | |
2. View **cluster1.yaml** to ensure there are no tokens (i.e. SSH keys or cloud credentials). You can make any changes you want as well. |
Mostly for consistency reasons, although it's fairly unlikely for the Docker provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiannistri you should not need those for docker provider
Description
This change restructures the providers section under
Reference Guides
which now contains, apart from the table with supported providers, provisioning examples for the most important providers: CAPA and Kubeadm+CAPD. This is added to theGetting Started
example based on CAPRKE2+CAPD.These two new examples include pre-configured sample templates so users can test CAPI provisioning with a basic cluster deployment.
Addresses some of the requirements from #117. Documenting RKE2+EC2 is still pending.