Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CAPIProvider example and replace clusterctl mentions #168

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

  • Provide minimum CAPIProvider resource configuration for quick-start with AKS.
  • Remove usage of clusterctl in favor of envsubst and curl to remove requirement for clusterctl init execution in the user clusters to run clusterctl generate later.
  • Fix link for caprke2 aws template

clusterctl generate works in presence of core CAPI provider, which is
provisioned with `clusterctl init`. This functionality overlaps with
turtles core CAPIProvider, and may cause issues.

Signed-off-by: Danil-Grigorev <[email protected]>
@@ -131,7 +128,7 @@ kubectl create -f cluster1.yaml
:::tip
After your cluster is provisioned, you can check functionality of the workload cluster using `clusterctl`:
```bash
clusterctl describe cluster cluster1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was an ugly one. Good catch!

Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM

docs/reference-guides/providers/howto.md Outdated Show resolved Hide resolved
@Danil-Grigorev Danil-Grigorev merged commit 0382b39 into rancher:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants