feat: add dockerfile cross-compilation for multi-platform images #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
kind/enhancement
yiannistri
reviewed
Jan 20, 2025
There was a problem hiding this comment.
For reference, here is the list of multi-platform build arguments. The release GHA is calling make docker-build-and-push and uses the $(TARGET_PLATFORMS) variable which is set to linux/amd64,linux/arm64.
I need to test how Tilt behaves with this change.
alexander-demicev
added
area/build-and-release
| @@ -17,7 +17,8 @@ | |||
| # Build the manager binary | |||
| ARG builder_image | |||
|
|
|||
| FROM ${builder_image} as builder | |||
| #FROM ${builder_image} as builder | |||
| FROM --platform=$BUILDPLATFORM ${builder_image} as builder | |||
There was a problem hiding this comment.
where is BUILDPLATFORM arg defined?
There was a problem hiding this comment.
BUILDPLATFORM is one of the pre-defined build arguments that is available to any build: https://docs.docker.com/build/building/variables/#multi-platform-build-arguments
yiannistri
reviewed
Jan 21, 2025
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
docker-faster-image-building
branch
from
011bb04 to
fbf4894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use cross-compilation when building the image with
buildx. This means that the process does not need to use emulation for the whole build which makes it considerably faster.We can use the existing build arguments (which are globally available):
BUILDPLATFORM: make the image always native to the machine.TARGETOSandTARGETARCH: configure the compiler process for the specific architecture.Which issue(s) this PR fixes:
Fixes #933
Special notes for your reviewer:
I ran a quick test and image building is a few minutes faster after this change.
Checklist: