-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove embedded-capi feature #1029
Remove embedded-capi feature #1029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add an e2e test for rancherInstalled=false
related issue #1025
Signed-off-by: Andrea Mazzotti <[email protected]>
35e8033
f9ecd24
to
35e8033
Compare
@furkatgofurov7 No that is good as it is and still required. It can be improved by the helm chart by not overriding an already |
What this PR does / why we need it:
This PR removes the embedded-capi feature, since it's now managed by the pre-install job and it is recommended to let the Turtles chart manage this setting.
The test suites have also been removed.
Also note that this will have the side effect of always creating the following resource:
Rancher does not seem to create it by default (as other Features are).
The Turtles chart will create it or override any existing, which is the desired behavior, however the chart will not clean this up.
The documentation already covers this: https://turtles.docs.rancher.com/turtles/v0.15/en/getting-started/uninstall_turtles.html
Test run: https://github.com/rancher/turtles/actions/runs/12903793122
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: